Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

librbd: don't continue to remove an image w/ incompatible features #12638

Merged
merged 1 commit into from Jan 6, 2017

Conversation

yangdongsheng
Copy link
Contributor

Fixes: http://tracker.ceph.com/issues/18315
Signed-off-by: Dongsheng Yang <dongsheng.yang@easystack.cn>
@yangdongsheng
Copy link
Contributor Author

I don't think this is what Jason suggests as a fix for this issue. I had impression he wanted we check for incompatible features, while you just make it to abort when it fails to open the image.

@trociny IMO, the open operation will check the incompatible features, I want to reuse it. then abort the removal here. then it should be that:

if (r == -ENOSYS)
    return r;

But at the same time, I think we should only allow removal to continue when we got an -ENOENT in opening. So it turns out to be what it looks in this PR.

Copy link

@dillaman dillaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm -- solves issues like permission problems, incompatible features, etc.

@dillaman dillaman merged commit 21a8c69 into ceph:master Jan 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants