msg/async/rdma: fix RoCE v2 deafult value #12648
Conversation
For backward compatibility, if no GID given or given GID is malformed, use GID index 0. Change-Id: I8c8ecbcfc0261e58c5a226ef6bc91297ec756182 Signed-off-by: Oren Duer <oren@mellanox.com> Adir Lev <adirl@mellanox.com> Signed-off-by: Adir Lev <adirl@mellanox.com>
|
@yuyuyu101 pls see fixes to RoceV2 support |
| @@ -224,7 +224,7 @@ OPTION(ms_async_rdma_receive_buffers, OPT_U32, 10240) | |||
| OPTION(ms_async_rdma_port_num, OPT_U32, 1) | |||
| OPTION(ms_async_rdma_polling_us, OPT_U32, 1000) | |||
| OPTION(ms_async_rdma_local_gid, OPT_STR, "") // GID format: "fe80:0000:0000:0000:7efe:90ff:fe72:6efe", no zero folding | |||
| OPTION(ms_async_rdma_roce_ver, OPT_INT, 2) // 2=RoCEv2, 1=RoCEv1.5, 0=RoCEv1 | |||
| OPTION(ms_async_rdma_roce_ver, OPT_INT, 1) // 0=RoCEv1, 1=RoCEv2, 2=RoCEv1.5 | |||
There was a problem hiding this comment.
could we get roce version by giving local_gid? like cat from /sys?
There was a problem hiding this comment.
same for local gid, could we only set gid index and getting others by code?
I'm thinking to find a way let user could use auto deploy tool instead of configurate roce in each host
There was a problem hiding this comment.
currently user must provide local_gid in ceph.conf per machine,
code does the rest according to the gid provided
RDMA-CM will solve all this issues and we can then use one conf for all.
There was a problem hiding this comment.
using gid index could have been a good idea,
but... no guaranty on index ordering in machine and between machines
so we cannot rely on that
For backward compatibility, if no GID given or given GID is malformed,
use GID index 0.
Signed-off-by: Oren Duer oren@mellanox.com Adir Lev adirl@mellanox.com
Signed-off-by: Adir Lev adirl@mellanox.com