New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc/dev: update log_based_pg.rst, fix some display problem #12730
Conversation
3. Whether we choose the oldest or newest possible head entry | ||
during peering | ||
4. A bit of extra information in the log entry to enable rollback | ||
1. How reads work -- async only, requires remote reads for ec |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could use
#. item 1
#. item 2
for ordered list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK~ i'm working on this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done. I edit this on github's online editor. Need I squash these commits?
By the way. The ceph docuemnt website is broken. I sent a email to dev-maillist yesterday. It's still broken now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need I squash these commits?
please do so.
and the first item is not changed yet.
By the way. The ceph docuemnt website is broken. I sent a email to dev-maillist yesterday. It's still broken now.
probably people are still on vacation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
😸 happy new year.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
happy new year to you!
408e1e0
to
97319dd
Compare
PGBackend and PGTransaction enables abstraction of differences 1, 2, | ||
#. All of the stats and metadata for objects | ||
#. The high level locking rules for mixing client IO with recovery and scrub | ||
#. The high level locking rules for mixing reads and writes without exposing uncommitted state (which might be rolled back or forgotten later) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you wrap the line at 80 chars?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how to make it? seems that RST‘s list doesn't support this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i find a method http://docutils.sourceforge.net/docs/ref/rst/restructuredtext.html#line-blocks
i will fix this tomorrow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i find a method http://docutils.sourceforge.net/docs/ref/rst/restructuredtext.html#line-blocks
i will fix this tomorrow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@liuchang0812 for instance, you can simply put
#. How writes work -- either restricted to append, or must write aside
and do a tpc
sphinx will render it just right. i tested locally. you can try using admin/build-doc
to verify the generated html.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes it works.
but Bullet Lists can't break lines, I use the line-blocks only for "-". Take a look please
Signed-off-by: liuchang0812 <liuchang0812@gmail.com>
4942c8c
to
5fa0a01
Compare
thanks for reviewing |
Signed-off-by: liuchang0812 liuchang0812@gmail.com