Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc/dev: update log_based_pg.rst, fix some display problem #12730

Merged
merged 1 commit into from Jan 3, 2017

Conversation

liuchang0812
Copy link
Contributor

Signed-off-by: liuchang0812 liuchang0812@gmail.com

3. Whether we choose the oldest or newest possible head entry
during peering
4. A bit of extra information in the log entry to enable rollback
1. How reads work -- async only, requires remote reads for ec
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could use

#. item 1
#. item 2

for ordered list

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK~ i'm working on this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done. I edit this on github's online editor. Need I squash these commits?

By the way. The ceph docuemnt website is broken. I sent a email to dev-maillist yesterday. It's still broken now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need I squash these commits?

please do so.

and the first item is not changed yet.

By the way. The ceph docuemnt website is broken. I sent a email to dev-maillist yesterday. It's still broken now.

probably people are still on vacation?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

😸 happy new year.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

happy new year to you!

PGBackend and PGTransaction enables abstraction of differences 1, 2,
#. All of the stats and metadata for objects
#. The high level locking rules for mixing client IO with recovery and scrub
#. The high level locking rules for mixing reads and writes without exposing uncommitted state (which might be rolled back or forgotten later)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you wrap the line at 80 chars?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how to make it? seems that RST‘s list doesn't support this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liuchang0812 for instance, you can simply put

#. How writes work -- either restricted to append, or must write aside
   and do a tpc

sphinx will render it just right. i tested locally. you can try using admin/build-doc to verify the generated html.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes it works.

but Bullet Lists can't break lines, I use the line-blocks only for "-". Take a look please

Signed-off-by: liuchang0812 <liuchang0812@gmail.com>
@tchaikov tchaikov merged commit 5438864 into ceph:master Jan 3, 2017
@tchaikov tchaikov self-assigned this Jan 3, 2017
@liuchang0812 liuchang0812 deleted the fix-dev-doc-pglog branch January 3, 2017 06:58
@liuchang0812
Copy link
Contributor Author

thanks for reviewing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants