NVMEDevice: optimize sector_size usage #12780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liupan1111
reviewed
Jan 4, 2017
| block_size = std::max(CEPH_PAGE_SIZE, spdk_nvme_ns_get_sector_size(ns)); | ||
| size = spdk_nvme_ns_get_sector_size(ns) * spdk_nvme_ns_get_num_sectors(ns); | ||
| block_size = std::max(CEPH_PAGE_SIZE, sector_size); | ||
| size = sector_size * spdk_nvme_ns_get_num_sectors(ns); |
There was a problem hiding this comment.
sector_size is 32bit, spdk_nvme_ns_get_num_sectors returns 64bit. and the temp result may be 32bit or 64 bit, which depends on OS. If 32bit os, the result may over flow.
There was a problem hiding this comment.
@liupan1111 The result is put in size (which is uint64_t), so...
spdk_nvme_ns_get_sector_size returns 32 bit size, so we just use 32 bit size for sector_size. Signed-off-by: optimistyzy <optimistyzy@gmail.com>
liupan1111
approved these changes
Jan 5, 2017
yuyuyu101
approved these changes
Jan 5, 2017
|
@yuyuyu101 @liupan1111 @tchaikov Could this patch and #12776 be merged? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spdk_nvme_ns_get_sector_size returns 32 bit size,
so we just use 32 bit size for sector_size.
Signed-off-by: optimistyzy optimistyzy@gmail.com