rgw multisite: fix ref counting of completions #12841
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes two cases where a
RGWAioCompletionNotifier
reference is leaked:RGWCompletionManager::go_down()
cancels registered notifiers, so they don't call back intounregister_completion_notifier()
to drop their refRGWAsyncRadosRequest::finish()
is called beforesend_request()
can callnotifier->cb()
(which drops a ref)