librbd: refactor exclusive lock support into generic managed lock #12846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ricardo Dias <rdias@suse.com>
Signed-off-by: Ricardo Dias <rdias@suse.com>
Signed-off-by: Ricardo Dias <rdias@suse.com>
Signed-off-by: Ricardo Dias <rdias@suse.com>
Fixes: http://tracker.ceph.com/issues/17016 Signed-off-by: Ricardo Dias <rdias@suse.com>
Signed-off-by: Ricardo Dias <rdias@suse.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
It's currently being incorrectly invoked twice -- but the direct callback is holding the Watcher lock. This results in a recursive lock when ManagedLock attempts to retrieve the watch id from the Watcher. Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
|
@trociny Care to give the last few commits a super-quick once-over? I've run this through teuthology: http://pulpito.ceph.com/jdillaman-2017-01-09_09:56:39-rbd-wip-rbd-mirror-ha-merge-distro-basic-smithi/ The test failures were related to bugs in the current wip-rbd-mirror-ha branch that I have fixed in the last two commits. |
|
@ceph-jenkins retest this please |
trociny
approved these changes
Jan 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.