os/bluestore: use Best-Effort policy when evicting onode from cache #12876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So, my concern here, and the reason it does what it does, is that I was worried about a situation where we have lots of onodes that still have refs and trim ends up iterating over N pinned entries each time it is called. Perhaps we can add in a second threshold so that we only iterate over a limited number of pinned entries before giving up so that we don't spend too much CPU time? bluestore_cache_trim_max_skip_pinned or something along those lines? |
xiexingguo
force-pushed
the
xxg-wip-be-for-cache
branch
from
3d73cb8
to
78cc0ad
Compare
We want a precise control of cache usage, and BE can achieve this goal in a better way. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
|
Updated. |
liewegas
approved these changes
Jan 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want a precise control of cache usage, and BE can achieve this goal
in a better way.
Signed-off-by: xie xingguo xie.xingguo@zte.com.cn