msg: client bind #12901
msg: client bind #12901
Conversation
|
refactor from #7256 |
|
we also met this problem when public and cluster are different net but can be interconnect. when injecting public network fault, it will cause mon electing always and osd false down |
Signed-off-by: Haomai Wang <haomai@xsky.com>
Signed-off-by: Haomai Wang <haomai@xsky.com>
Signed-off-by: Haomai Wang <haomai@xsky.com>
yuyuyu101
force-pushed
the
wip-msgr-client-bind
branch
2 times, most recently
from
9a58f6b
to
dbb737d
Compare
| @@ -859,6 +859,18 @@ ssize_t AsyncConnection::_process_connection() | |||
| cs.close(); | |||
| } | |||
|
|
|||
| { | |||
| entity_addr_t addr2bind = msgr->get_myaddr(); | |||
| if (msgr->cct->ms_bind_before_connect && (!addr2bind.is_blank_ip())) { | |||
There was a problem hiding this comment.
get_myaddr() returns by reference, right? can use it directly instead of copying the value to addr2bind
There was a problem hiding this comment.
eh, i guess if we have this option enabled by default it doesn't matter
There was a problem hiding this comment.
we will modify addr2bind, so nonreference is suitable
/home/jenkins-build/build/workspace/ceph-pull-requests/src/msg/simple/Pipe.cc: In member function ‘int Pipe::accept()’:
/home/jenkins-build/build/workspace/ceph-pull-requests/src/msg/simple/Pipe.cc:361:20: error: ‘class CephContext’ has no member named ‘ms_bind_before_connect’
if (msgr->cct->ms_bind_before_connect && (!addr2bind.is_blank_ip())) {
^
|
|
retest this please |
yuyuyu101
force-pushed
the
wip-msgr-client-bind
branch
11 times, most recently
from
952938b
to
80c1b68
Compare
| @@ -563,6 +573,9 @@ int main(int argc, const char **argv) | |||
| r = ms_hb_front_server->bind(hb_front_addr); | |||
| if (r < 0) | |||
| exit(1); | |||
| r = ms_hb_front_client->client_bind(hb_back_addr); | |||
There was a problem hiding this comment.
@yuriw sorry, I have a mistake. you may need to update this pr to branch and schedule qa
Signed-off-by: Zengran Zhang <zhangzengran@h3c.com> Signed-off-by: Haomai Wang <haomai@xsky.com>
yuyuyu101
force-pushed
the
wip-msgr-client-bind
branch
from
80c1b68
to
6e4ed29
Compare
| { | ||
| lock.Lock(); | ||
| if (did_bind) { | ||
| assert(my_inst.addr == bind_addr); |
There was a problem hiding this comment.
seems that miss lock.Unlock() ?
|
It looks like this will break librados functionality when used behind a NAT since it learns the address of the gateway and then attempts to bind using it instead of its local IP address [1]. |
No description provided.