common: misc fixes detected by crypto shutdown assert #12925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were leaking several heap items from LibRadosMiscConnectFailure.ConnectFailure when connect() was called multiple times (after failure). Use std::unique_ptr to avoid maintaining fragile cleanup paths. Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
This can happen if we trigger an assertion while g_ceph_context is being torn down. Signed-off-by: Sage Weil <sage@redhat.com>
We can dump the backtrace regardless of where we hit the assertion. Signed-off-by: Sage Weil <sage@redhat.com>
|
test this please |
badone
approved these changes
Jan 15, 2017
| ostringstream oss; | ||
| bt.print(oss); | ||
| dout_emergency(oss.str()); | ||
|
|
There was a problem hiding this comment.
Just a thought here. Would this code benefit from Kefu's PR 9028 ?
|
Not in this case, I think, because dout_emergency takes a string?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are fixes uncovered by #12624, without the assert on shutdown that
helped find them (since not all leaks have been found yet).