osdc: cache should ignore error bhs during trim #12966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A read error (such as injecting a timeout into an OSD op) might result in a bh in an error state. These should be trimable by the cache. Fixes: http://tracker.ceph.com/issues/18436 Signed-off-by: Jason Dillaman <dillaman@redhat.com>
|
Since you tagged this as CephFS, LGTM at a quick glance. |
jcsp
approved these changes
Jan 27, 2017
|
@dillaman this passed the fs suite here: http://pulpito.ceph.com/jspray-2017-01-27_11:40:25-fs-wip-jcsp-testing-20170126-distro-basic-smithi, did you also want to run the rbd suite against it? |
|
@jcsp I included this in an rbd suite run w/ another PR and no issues popped up (at least related to this PR). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A read error (such as injecting a timeout into an OSD op) might result
in a bh in an error state. These should be trimable by the cache.
Fixes: http://tracker.ceph.com/issues/18436
Signed-off-by: Jason Dillaman dillaman@redhat.com