osd/osd_types: clean up OSDOp printers #12980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiexingguo
reviewed
Jan 19, 2017
| case CEPH_OSD_OP_SPARSE_READ: | ||
| case CEPH_OSD_OP_SYNC_READ: | ||
| case CEPH_OSD_OP_WRITE: | ||
| case CEPH_OSD_OP_WRITE_FULL: |
There was a problem hiding this comment.
It's CEPH_OSD_OP_WRITEFULL...
There was a problem hiding this comment.
might want to include CEPH_OSD_OP_MAPEXT here also.
tchaikov
requested changes
Jan 19, 2017
| case CEPH_OSD_OP_SPARSE_READ: | ||
| case CEPH_OSD_OP_SYNC_READ: | ||
| case CEPH_OSD_OP_WRITE: | ||
| case CEPH_OSD_OP_WRITE_FULL: |
There was a problem hiding this comment.
might want to include CEPH_OSD_OP_MAPEXT here also.
liewegas
force-pushed
the
wip-osdop-printer
branch
from
5f3cea8
to
7261422
Compare
|
@xiexingguo @tchaikov fixed |
xiexingguo
approved these changes
Jan 20, 2017
tchaikov
approved these changes
Jan 20, 2017
Specify which ones get offset~length instead of blacklisting those that don't. Signed-off-by: Sage Weil <sage@redhat.com>
liewegas
force-pushed
the
wip-osdop-printer
branch
from
7261422
to
1bda017
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify which ones get offset~length instead of blacklisting those that
don't.
Signed-off-by: Sage Weil sage@redhat.com