New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd/osd_types: clean up OSDOp printers #12980

Merged
merged 1 commit into from Jan 22, 2017

Conversation

Projects
None yet
3 participants
@liewegas
Member

liewegas commented Jan 18, 2017

Specify which ones get offset~length instead of blacklisting those that
don't.

Signed-off-by: Sage Weil sage@redhat.com

case CEPH_OSD_OP_SPARSE_READ:
case CEPH_OSD_OP_SYNC_READ:
case CEPH_OSD_OP_WRITE:
case CEPH_OSD_OP_WRITE_FULL:

This comment has been minimized.

@xiexingguo

xiexingguo Jan 19, 2017

Member

It's CEPH_OSD_OP_WRITEFULL...

This comment has been minimized.

@tchaikov

tchaikov Jan 19, 2017

Contributor

might want to include CEPH_OSD_OP_MAPEXT here also.

case CEPH_OSD_OP_SPARSE_READ:
case CEPH_OSD_OP_SYNC_READ:
case CEPH_OSD_OP_WRITE:
case CEPH_OSD_OP_WRITE_FULL:

This comment has been minimized.

@tchaikov

tchaikov Jan 19, 2017

Contributor

might want to include CEPH_OSD_OP_MAPEXT here also.

@liewegas

This comment has been minimized.

Member

liewegas commented Jan 19, 2017

@liewegas liewegas added the needs-qa label Jan 20, 2017

osd/osd_types: clean up OSDOp printers
Specify which ones get offset~length instead of blacklisting those that
don't.

Signed-off-by: Sage Weil <sage@redhat.com>

@liewegas liewegas merged commit 65f5187 into ceph:master Jan 22, 2017

0 of 3 checks passed

Signed-off-by checking if commits are signed
Details
Unmodifed Submodules checking if PR has modified submodules
Details
default Build triggered. sha1 is merged.
Details

@liewegas liewegas deleted the liewegas:wip-osdop-printer branch Jan 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment