Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os: extend ObjectStore interface to dump store's performance counters #13203

Merged
merged 5 commits into from Feb 1, 2017

Conversation

ifed01
Copy link
Contributor

@ifed01 ifed01 commented Jan 31, 2017

No description provided.

Igor Fedotov added 2 commits January 31, 2017 14:28
Signed-off-by: Igor Fedotov <ifedotov@mirantis.com>
Signed-off-by: Igor Fedotov <ifedotov@mirantis.com>
@ifed01 ifed01 changed the title test/fio: add store's performance counters dump on completion os: extend ObjectStore interface to dump store's performance counters Jan 31, 2017
Igor Fedotov added 3 commits January 31, 2017 14:30
Signed-off-by: Igor Fedotov <ifedotov@mirantis.com>
Signed-off-by: Igor Fedotov <ifedotov@mirantis.com>
Signed-off-by: Igor Fedotov <ifedotov@mirantis.com>
@liuchang0812
Copy link
Contributor

hi, @ifed01 Where will it be used? We will provide a command in OSD's asock?

@ifed01
Copy link
Contributor Author

ifed01 commented Jan 31, 2017

@liuchang0812 - An opportunity to access performance counters via admin sockets (and hence from CLI) already exists.
See http://docs.ceph.com/docs/giant/dev/perf_counters/
This patch is needed for fio objectstore plugin. And probably makes sense for other testing tools and unit tests that lack command interfaces.

@liuchang0812
Copy link
Contributor

@ifed01 sounds great! thanks for your explanation.

@liewegas liewegas merged commit 09d23e8 into ceph:master Feb 1, 2017
@ifed01 ifed01 deleted the wip-bluestore-more-dump branch February 3, 2017 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants