rgw: swift: fix anonymous user's error code of getting object #13242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzarzynski
approved these changes
Feb 3, 2017
| @@ -17,6 +17,7 @@ class RGWGetObj_ObjStore_SWIFT : public RGWGetObj_ObjStore { | |||
| RGWGetObj_ObjStore_SWIFT() {} | |||
| ~RGWGetObj_ObjStore_SWIFT() {} | |||
|
|
|||
| int verify_permission() override; | |||
There was a problem hiding this comment.
I'm 100% behind the override. Thanks!
|
@Jing-Scott: the results look OK. Could you please alter the commit message to have:
I mean something like this example below: |
The openstack swift will return 401 rather than 403 when the anon user has no permission to get objects. Fixes: http://tracker.ceph.com/issues/18806 Signed-off-by: Jing Wenjun <jingwenjun@cmss.chinamobile.com>
Jing-Scott
force-pushed
the
dev/fix-swift-anon-getobj-error-code
branch
from
184842e
to
318de28
Compare
|
@rzarzynski : okay, no problem! done :) |
|
@Jing-Scott: merged. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The openstack swift will return 401 rather than 403 when the anon user has no permission to get objects.
Fixes: http://tracker.ceph.com/issues/18806
Signed-off-by: Jing Wenjun jingwenjun@cmss.chinamobile.com