ceph: do not throw TypeError on connection failure #13268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaikov
changed the title
otherwise we could concat None with a string on connection problem. which will result in TypeError. and the caller will print misleading error like Error connecting to cluster: TypeError see also ceph#12934 Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov
force-pushed
the
wip-better-error-ping-mon
branch
from
d3ccfc4
to
d832c0e
Compare
liewegas
approved these changes
Feb 6, 2017
jdurgin
approved these changes
Feb 6, 2017
hjwsm1989
pushed a commit
to hjwsm1989/ceph
that referenced
this pull request
Feb 23, 2017
Fixes: ceph#13268 Signed-off-by: Yan, Zheng <zyan@redhat.com> (cherry picked from commit f04c8da)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
otherwise we could concat None with a string on connection problem.
which will result in TypeError. and the caller will print misleading
error like
Error connecting to cluster: TypeError
see also #12934
Signed-off-by: Kefu Chai kchai@redhat.com