cmake: link consumers of libclient with libcommon #13394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to avoid linking against to both libceph-common and libcommon at the same time, because both of them will be registered as a provider of lttng provider. Fixes: http://tracker.ceph.com/issues/18838 Signed-off-by: Kefu Chai <kchai@redhat.com>
Signed-off-by: Kefu Chai <kchai@redhat.com>
badone
reviewed
Feb 14, 2017
| } | ||
|
|
||
| void usage() | ||
| { | ||
| cout << |
There was a problem hiding this comment.
Should this be its own separate PR? Seems unrelated to the linking changes.
There was a problem hiding this comment.
the PR tries to fix the mem leak issues reported by valgrind, that's why i think this cleanup could be part of it.
There was a problem hiding this comment.
OK. That's probably worth a mention in the commit message?
There was a problem hiding this comment.
Doh! Of course the tracker mentions them. Sorry @tchaikov
|
Valgrind issues look to be fixed by this: http://pulpito.ceph.com/jspray-2017-02-14_02:39:19-fs-wip-jcsp-testing-20170214-distro-basic-smithi/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.