osd: drop support for listing objects at a given snap #13398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This made us wait if the snapid != CEPH_NOSNAP and there were any missing objects at all. Objecter can't submit such ops, and we're dropping support for listing at a specific snap anyway. Signed-off-by: Sage Weil <sage@redhat.com>
This was super slow, and Objecter was incapable of generating the requests to use it. To do this properly we should create a new listing op that returns the set of clones and/or snaps for each object as part of a single listing result. If/when the need arises. Signed-off-by: Sage Weil <sage@redhat.com>
gregsfortytwo
approved these changes
Feb 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was never used (Objecter is hard-coded to CEPH_NOSNAP for pg ops), is inefficient,
and a bad API for getting this info out of the OSD.