os/bluestore: add flush_store_cache cmd #13428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiexingguo
force-pushed
the
wip-flush-cache
branch
from
4e00bf9
to
72fa7ba
Compare
liewegas
reviewed
Feb 15, 2017
| r = admin_socket->register_command("flush_store_cache", | ||
| "flush_store_cache", | ||
| asok_hook, | ||
| "Flush bluestore internal cache"); |
There was a problem hiding this comment.
there are unregister_command calls as well
|
otherwise lgtm! |
xiexingguo
force-pushed
the
wip-flush-cache
branch
from
72fa7ba
to
650d9d0
Compare
We want this cmd for bluestore testing, e.g., to exclude the impact of
the bluestore internal cache without rebooting host.
e.g.:
[root@tecs131 ~]# ceph --admin-daemon /run/ceph/ceph-osd.1.asok perf dump | grep "bluestore_buffers"
"bluestore_buffers": 3166,
[root@tecs131 ~]# ceph --admin-daemon /run/ceph/ceph-osd.1.asok flush_store_cache
[root@tecs131 ~]# ceph --admin-daemon /run/ceph/ceph-osd.1.asok perf dump | grep "bluestore_buffers"
"bluestore_buffers": 95,
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
liewegas
approved these changes
Feb 16, 2017
|
retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want this cmd for bluestore testing, e.g., to exclude the impact of
the bluestore internal cache without rebooting host.
e.g.:
[root@tecs131 ~]# ceph --admin-daemon /run/ceph/ceph-osd.1.asok perf dump | grep "bluestore_buffers"
"bluestore_buffers": 3166,
[root@tecs131 ~]# ceph --admin-daemon /run/ceph/ceph-osd.1.asok flush_store_cache
[root@tecs131 ~]# ceph --admin-daemon /run/ceph/ceph-osd.1.asok perf dump | grep "bluestore_buffers"
"bluestore_buffers": 95,
Signed-off-by: xie xingguo xie.xingguo@zte.com.cn