New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os/bluestore: add flush_store_cache cmd #13428

Merged
merged 1 commit into from Feb 18, 2017

Conversation

Projects
None yet
3 participants
@xiexingguo
Member

xiexingguo commented Feb 15, 2017

We want this cmd for bluestore testing, e.g., to exclude the impact of
the bluestore internal cache without rebooting host.

e.g.:
[root@tecs131 ~]# ceph --admin-daemon /run/ceph/ceph-osd.1.asok perf dump | grep "bluestore_buffers"
"bluestore_buffers": 3166,
[root@tecs131 ~]# ceph --admin-daemon /run/ceph/ceph-osd.1.asok flush_store_cache
[root@tecs131 ~]# ceph --admin-daemon /run/ceph/ceph-osd.1.asok perf dump | grep "bluestore_buffers"
"bluestore_buffers": 95,

Signed-off-by: xie xingguo xie.xingguo@zte.com.cn

r = admin_socket->register_command("flush_store_cache",
"flush_store_cache",
asok_hook,
"Flush bluestore internal cache");

This comment has been minimized.

@liewegas

liewegas Feb 15, 2017

Member

there are unregister_command calls as well

@liewegas

liewegas Feb 15, 2017

Member

there are unregister_command calls as well

This comment has been minimized.

@xiexingguo

xiexingguo Feb 16, 2017

Member

fixed:-)

@xiexingguo

xiexingguo Feb 16, 2017

Member

fixed:-)

@liewegas

This comment has been minimized.

Show comment
Hide comment
@liewegas

liewegas Feb 15, 2017

Member

otherwise lgtm!

Member

liewegas commented Feb 15, 2017

otherwise lgtm!

os/bluestore: add flush_store_cache cmd
We want this cmd for bluestore testing, e.g., to exclude the impact of
the bluestore internal cache without rebooting host.

e.g.:
[root@tecs131 ~]# ceph --admin-daemon /run/ceph/ceph-osd.1.asok perf dump | grep "bluestore_buffers"
        "bluestore_buffers": 3166,
[root@tecs131 ~]# ceph --admin-daemon /run/ceph/ceph-osd.1.asok flush_store_cache
[root@tecs131 ~]# ceph --admin-daemon /run/ceph/ceph-osd.1.asok perf dump | grep "bluestore_buffers"
        "bluestore_buffers": 95,

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>

@liewegas liewegas added the needs-qa label Feb 16, 2017

@xiexingguo

This comment has been minimized.

Show comment
Hide comment
@xiexingguo

xiexingguo Feb 16, 2017

Member

retest this please

Member

xiexingguo commented Feb 16, 2017

retest this please

@tchaikov tchaikov merged commit bb62167 into ceph:master Feb 18, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@xiexingguo xiexingguo deleted the xiexingguo:wip-flush-cache branch Feb 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment