pybind: cephfs should be built without librados / python-rados #13431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaikov
force-pushed
the
wip-cython-cephfs-without-librados
branch
2 times, most recently
from
d1b7b1f
to
08e2423
Compare
instead, it "Recommends" python-rados. as "Recommends:" is not supported on older distros, only enable this on SuSE. because python-cephfs *can* be used without python-rados. the constructor of LibCephFS accepts a ceph.conf *or* a rados.Rados instance. Signed-off-by: Kefu Chai <kchai@redhat.com>
so cstr() prints the right error message if auth_id does not look right. Signed-off-by: Kefu Chai <kchai@redhat.com>
Signed-off-by: Kefu Chai <kchai@redhat.com>
otherwise python-cephfs might fail to build with followin error: Scanning dependencies of target cython3_cephfs /usr/bin/ld: cannot find -lrados collect2: error: ld returned 1 exit status Link Error: Ceph FS library not found and apparently, cephfs *can* be built without librados. it's only dependency is libcephfs. Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov
force-pushed
the
wip-cython-cephfs-without-librados
branch
from
08e2423
to
a7f8390
Compare
|
LGTM |
smithfarm
approved these changes
Feb 15, 2017
b-ranto
approved these changes
Feb 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this addresses the build failure at https://jenkins.ceph.com/job/ceph-dev-new-build/ARCH=x86_64,AVAILABLE_ARCH=x86_64,AVAILABLE_DIST=centos7,DIST=centos7,MACHINE_SIZE=huge/1284//consoleFull , and includes some cleanups along the way.