rbd: add override in rbd subsystem

[liuchang0812]

Fixes: http://tracker.ceph.com/issues/18922

Signed-off-by: liuchang0812 liuchang0812@gmail.com

[dillaman]

Nit: since the "override" keyword isn't being applied, I would prefer to keep the "virtual" keyword on virtual destructors to highlight that fact.

[liuchang0812]

hi dillaman, thanks

FYI here isocpp/CppCoreGuidelines#737

CppCoreGuide said it's not prefer

[dillaman]

However, that violates the Ceph coding style (derived from Google's C++ Style Guide [1]):

Explicitly annotate overrides of virtual functions or virtual destructors with an override or (less frequently) final specifier. Older (pre-C++11) code will use the virtual keyword as an inferior alternative annotation. For clarity, use exactly one of override, final, or virtual when declaring an override. Rationale: A function or destructor marked override or final that is not an override of a base class virtual function will not compile, and this helps catch common errors. The specifiers serve as documentation; if no specifier is present, the reader has to check all ancestors of the class in question to determine if the function or destructor is virtual or not.

[1] https://google.github.io/styleguide/cppguide.html#Inheritance

[liuchang0812]

So, is ~destructor() override OK? I could make it automatically.

btw, @jcfischer @cbodley take a look please, we talked yet here [1]

[1] https://github.com/ceph/ceph/pull/13414/files/43c8b32ac7c57ae15b19e27bd69c04c75e296a4d#diff-89c2e65135de8a3db3f4ffe984ed8cc9

[cbodley]

my comment there suggested removing an empty destructor to dodge this issue :) i agree with @dillaman that we should stick to our style guide here

[dillaman]

I'm fine w/ ~destructor() override

[liuchang0812]

Thanks @dillaman @cbodley , I will update this PR to ~destructor() override soon.

@liewegas need we unify other PR?

[liuchang0812]

I have updated.

[liewegas]

👍

[dillaman]

lgtm

[dillaman]

@liuchang0812 just realized that this change didn't clean up everything in librbd -- see https://github.com/ceph/ceph/blob/master/src/librbd/AioImageRequest.h#L90 for an example

[liuchang0812]

@dillaman Thanks for your tip. virtual func() override case couldn't be resolved. I will have a try to make it automatically.

[dillaman]

@liuchang0812 ... and there are a couple more examples below that one where "virtual" was left w/o the "override" keyword: https://github.com/ceph/ceph/blob/master/src/librbd/AioImageRequest.h#L93

[liuchang0812]

@dillaman it seems that there are not introduced by this patch. Need I clean it?

[dillaman]

Correct -- it wasn't introduced by this patch, but I would have thought the tool would have cleaned all the files(?).

[liuchang0812]

No, clang-tidy only add override , it could not process this case. We could add this feature to it if we need this.

[dillaman]

@liuchang0812 what about the other cases where it was an override and it didn't add override and left virtual (line 93)?

[liuchang0812]

Ok. I'm looking. I'm not sure whether it's caused of that `get_aio_type` is a templated member function. 2017-02-17 22:25 GMT+08:00 Jason Dillaman <notifications@github.com>:

…

@liuchang0812 <https://github.com/Liuchang0812> what about the other cases where it was an override and it didn't add override and left virtual (line 93)? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#13437 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABtHdlX6K301GwjMtT-Vq5gElMaBdgzvks5rda3agaJpZM4MBvIE> .

[dillaman]

@liuchang0812 Quite possible -- I see lots of examples of missing "override" keywords in classes that derive from templated base-classes (which is a lot of classes in librbd).

[liuchang0812]

I would like to report this issue to LLVM team, It's easy bug to be fixed. 发自我的 iPhone

…

在 2017年2月17日，22:42，Jason Dillaman ***@***.***> 写道： @liuchang0812 Quite possible -- I see lots of examples of missing "override" keywords in classes that derive from templated base-classes (which is a lot of classes in librbd). — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[dillaman]

@liuchang0812 Thanks. BTW -- here is an example of a non-templated class where it failed to convert "virtual XYZ" to "XYZ override": https://github.com/ceph/ceph/blob/master/src/librbd/AioCompletion.h#L228

[liuchang0812]

I think i already know why clang-tidy doesn't process *.h files. Tidy must know how to compile each files so that I generated a json file by cmake CMAKE_EXPORT_COMPILE_COMMANDS option which contains compile commands of *.cc files only.

I would try to fix it this weekend.

Thanks a lot @dillaman

[liuchang0812]

@dillaman @liewegas I have fixed the problem that clang-type doesn't process header files. It will be a big changes. Should I make a PR?

[dillaman]

@liuchang0812 Sure -- I would do the same thing where you break it up by subsystem.

[liuchang0812]

OK. I will make a new PR soon. thanks 2017-02-20 20:53 GMT+08:00 Jason Dillaman <notifications@github.com>:

…

@liuchang0812 <https://github.com/Liuchang0812> Sure -- I would do the same thing where you break it up by subsystem. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#13437 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABtHdmyG4BbAtqhAqOVj9HJKBgfVEHLpks5reYy4gaJpZM4MBvIE> .