librbd: add override in header files #13536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dillaman
reviewed
Feb 20, 2017
src/librbd/AioImageRequest.h
Outdated
| virtual void send_object_cache_requests(const ObjectExtents &object_extents, | ||
| uint64_t journal_tid); | ||
| void send_object_cache_requests(const ObjectExtents &object_extents, | ||
| uint64_t journal_tid) override; |
src/librbd/AioImageRequest.h
Outdated
|
|
||
| virtual void send_object_requests(const ObjectExtents &object_extents, | ||
| void send_object_requests(const ObjectExtents &object_extents, | ||
| const ::SnapContext &snapc, |
src/librbd/AioImageRequest.h
Outdated
| bool synchronous); | ||
| virtual void update_stats(size_t length); | ||
| uint64_t append_journal_event(const AioObjectRequests &requests, | ||
| bool synchronous) override; |
src/librbd/AioImageRequest.h
Outdated
| uint64_t journal_tid); | ||
| uint32_t get_object_cache_request_count(bool journaling) const override; | ||
| void send_object_cache_requests(const ObjectExtents &object_extents, | ||
| uint64_t journal_tid) override; |
src/librbd/AioImageRequest.h
Outdated
| bool synchronous); | ||
| virtual void update_stats(size_t length); | ||
| uint64_t append_journal_event(const AioObjectRequests &requests, | ||
| bool synchronous) override; |
src/librbd/Watcher.h
Outdated
| @@ -114,11 +114,11 @@ class Watcher { | |||
|
|
|||
| WatchCtx(Watcher &parent) : watcher(parent) {} | |||
|
|
|||
| virtual void handle_notify(uint64_t notify_id, | |||
| void handle_notify(uint64_t notify_id, | |||
| uint64_t handle, | |||
| Context *on_finish); | ||
| virtual void aio_flush(Context *on_finish); | ||
| void aio_read(Extents&& image_extents, ceph::bufferlist *bl, | ||
| int fadvise_flags, Context *on_finish) override; |
| void aio_read(Extents&& image_extents, ceph::bufferlist *bl, | ||
| int fadvise_flags, Context *on_finish) override; | ||
| void aio_write(Extents&& image_extents, ceph::bufferlist&& bl, | ||
| int fadvise_flags, Context *on_finish) override; |
| void aio_write(Extents&& image_extents, ceph::bufferlist&& bl, | ||
| int fadvise_flags, Context *on_finish) override; | ||
| void aio_discard(uint64_t offset, uint64_t length, | ||
| Context *on_finish) override; |
| virtual void handle_notify(uint64_t notify_id, uint64_t handle, | ||
| uint64_t notifier_id, bufferlist &bl); | ||
| void handle_notify(uint64_t notify_id, uint64_t handle, | ||
| uint64_t notifier_id, bufferlist &bl) override; |
|
@dillaman what's wrong with indentation |
|
@liuchang0812 The params on the next line should align with the params on the previous line -- they don't now after the "virtual " keyword was removed. |
|
@dillaman thanks I don't know how to fix this by clang-tidy automatically , I will correct it by hands tomorrow |
liuchang0812
force-pushed
the
wip-add-override-in-rbd-headers
branch
2 times, most recently
from
4ef0b22
to
15a7402
Compare
liuchang0812
commented
Feb 21, 2017
src/tools/rbd_mirror/LeaderWatcher.h
Outdated
| virtual void pre_release_lock_handler(bool shutting_down, | ||
| Context *on_finish) { | ||
| void pre_release_lock_handler(bool shutting_down, | ||
| Context *on_finish) override { |
|
@dillaman It seems that I have fixed all indentation problems. Could you take a look again. Very thanks. |
|
There are some CE because I rebased branch. I'm fixing it. |
Fixes: http://tracker.ceph.com/issues/19012 Signed-off-by: liuchang0812 <liuchang0812@gmail.com>
liuchang0812
force-pushed
the
wip-add-override-in-rbd-headers
branch
from
15a7402
to
f72b881
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: http://tracker.ceph.com/issues/19012
Signed-off-by: liuchang0812 liuchang0812@gmail.com