Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qa/tasks/workunit: use the suite repo for cloning workunit #13452

Merged
merged 1 commit into from Feb 16, 2017

Conversation

tchaikov
Copy link
Contributor

as "workunits" reside in ceph/qa/workunits, it's more intuitive to
respect suite-repo option when cloning workunits.

Signed-off-by: Kefu Chai kchai@redhat.com

as "workunits" reside in ceph/qa/workunits, it's more intuitive to
respect suite-repo option when cloning workunits.

Signed-off-by: Kefu Chai <kchai@redhat.com>
@tchaikov
Copy link
Contributor Author

tchaikov commented Feb 16, 2017

see also ceph/teuthology#1030

i ran into this problem when testing #13448 but seems

teuthology-suite --filter="rados/objectstore/fusestore.yaml" --suite rados --machine-type=mira --ceph wip-kefu-testing --suite-repo https://github.com/dmick/ceph.git --suite-branch master

failed to checkout the workunit from https://github.com/dmick/ceph.git and it was still cloning from ceph-ci:master. hence the fix.

@liewegas liewegas added the tests label Feb 16, 2017
@tchaikov tchaikov merged commit 8f8c060 into ceph:master Feb 16, 2017
@tchaikov tchaikov deleted the wip-suite-repo-for-workunit branch February 16, 2017 15:40
@dillaman
Copy link

Hmm -- workunit tests are now failing to work due to this change: http://pulpito.ceph.com/jdillaman-2017-02-17_11:26:57-rbd-wip-jd-testing-distro-basic-smithi/

@liewegas
Copy link
Member

yeah, i saw the same too but wasn't sure

@dillaman
Copy link

dillaman commented Feb 17, 2017

@tchaikov When you resubmit this fix, there is a substring replace for "ceph-ci" -> "ceph" upon clone failure. I think if we are correctly tied to the suite branch (which I do really like), we should ensure that this code can be removed (and that is works for all possible cases such as ceph/ceph/master, ceph/ceph-ci/random, and /ceph/random).

smithfarm pushed a commit to SUSE/ceph that referenced this pull request Feb 22, 2017
… DLO.

Fixes: ceph#13452
Signed-off-by: Radoslaw Zarzynski <rzarzynski@mirantis.com>
(cherry picked from commit 66f47f3)
smithfarm pushed a commit to SUSE/ceph that referenced this pull request Feb 22, 2017
Fixes: ceph#13452
Signed-off-by: Radoslaw Zarzynski <rzarzynski@mirantis.com>
(cherry picked from commit b48f3d7)
@tchaikov
Copy link
Contributor Author

@dillaman thanks for the suggestion, updated PR is posted at #13625.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants