rgw: add override in header files mostly #13586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbodley
reviewed
Feb 22, 2017
src/rgw/rgw_rest.h
Outdated
| virtual void init(RGWRados *store, struct req_state *s, | ||
| RGWHandler *dialect_handler) { | ||
| void init(RGWRados *store, struct req_state *s, | ||
| RGWHandler *dialect_handler) override { |
src/rgw/rgw_rest_s3.h
Outdated
| struct req_state *s, | ||
| rgw::io::BasicClient *cio); | ||
| virtual int authorize() { | ||
| rgw::io::BasicClient *cio) override; |
src/rgw/rgw_rest_s3.h
Outdated
| struct req_state *s, | ||
| rgw::io::BasicClient *cio); | ||
| virtual int authorize() { | ||
| rgw::io::BasicClient *cio) override; |
src/rgw/rgw_swift_auth.h
Outdated
|
|
||
| virtual RGWRESTMgr *get_resource_mgr(struct req_state* const s, | ||
| RGWRESTMgr *get_resource_mgr(struct req_state* const s, |
src/rgw/rgw_swift_auth.h
Outdated
| const std::string& uri, | ||
| std::string* const out_uri) override { | ||
| return this; | ||
| } | ||
|
|
||
| virtual RGWHandler_REST* get_handler(struct req_state*, | ||
| RGWHandler_REST* get_handler(struct req_state*, |
|
@cbodley It seems that all issues have been cleaned. |
cbodley
approved these changes
Feb 23, 2017
|
@cbodley hi, could we merge it now? |
|
@liuchang0812 just trying to be careful about the timing for merge, because we'll need to rebase a lot of other PRs afterwards. what do you think, @yehudasa? is there stuff you want to get merged before this? |
|
@cbodley okay |
|
@cbodley @liuchang0812 yeah, let's get wip-bucket-cleanup in first. |
|
@liuchang0812 can you please rebase? |
|
copy that, I will rebase it soon
2017-03-14 3:23 GMT+08:00 Casey Bodley <notifications@github.com>:
… @liuchang0812 <https://github.com/Liuchang0812> can you please rebase?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#13586 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABtHdtBAhtUqE5ZAUUEGPXqdsb6uVcQUks5rlZeYgaJpZM4MIlNo>
.
|
liuchang0812
force-pushed
the
wip-add-override-in-rgw
branch
from
110f240
to
90ba70e
Compare
|
change log:
|
Signed-off-by: liuchang0812 <liuchang0812@gmail.com>
liuchang0812
force-pushed
the
wip-add-override-in-rgw
branch
from
90ba70e
to
3b24747
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: liuchang0812 liuchang0812@gmail.com