test/librbd/CMakeLists.txt: ceph_test_librbd_fsx requires linux includes/libs #13630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaikov
requested changes
Feb 24, 2017
src/test/librbd/CMakeLists.txt
Outdated
| @@ -123,6 +123,7 @@ target_link_libraries(ceph_test_librbd_api | |||
| set_target_properties(ceph_test_librbd_api PROPERTIES COMPILE_FLAGS | |||
| ${UNITTEST_CXX_FLAGS}) | |||
|
|
|||
| ifdef(LINUX) | |||
There was a problem hiding this comment.
probably what you meant is
if(DEFINED LINUX)but i'd suggest use
if(LINUX)for consistency.
but can we just disable the krbd support in fsx.cc? is there any other linux specific bits in it?
There was a problem hiding this comment.
@tchaikov
Arggh, sometimes my head overflows with all the syntax versions.
And I did not copy my wip-version because master changed too much.
And redoing it seemed easier.
have fixed/rebased.
…des/libs Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
wjwithagen
force-pushed
the
wip-wjw-fsx-linux
branch
from
45319b2
to
1827c69
Compare
dillaman
approved these changes
Feb 27, 2017
tchaikov
approved these changes
Feb 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Willem Jan Withagen wjw@digiware.nl