New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qa/tasks/workunit: use ceph.git as an alternative of ceph-ci.git for cloning workunit #13663
Conversation
it's a regression introduced by #13625 |
Ah, that's what it is for... No mention of "upgrade" in 72d73b8. Have you tested this? The except branch seems to use git_url and not alt_git_url? |
…workunit repo if we run upgrade test, where, for example, "jewel" is not in ceph-ci.git repo, we should check ceph.git to clone the workunits. Signed-off-by: Kefu Chai <kchai@redhat.com>
6a201c7
to
edceabb
Compare
@idryomov thanks for the review. fixed, and i am pushing this change to ceph-ci for testing. will update the PR with the link to the test run. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Should #13625 and this PR be backported? |
@smithfarm they improve the developer's user experience when testing using the tasks in qa suites. but it's not a user visible change. so i think it's just nice to backport them, but not required. |
Might want to hold the backporting for another week or two until we are sure there are no regressions. People seem to be having issues in this area: http://tracker.ceph.com/issues/19188. |
if we run upgrade test, where, for example, "jewel" is not in
ceph-ci.git repo, we should check ceph.git to clone the workunits.
this fixes http://pulpito.ceph.com/kchai-2017-02-27_04:13:29-rados-wip-kefu-testing---basic-smithi/862549/