Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qa/tasks/workunit: use ceph.git as an alternative of ceph-ci.git for cloning workunit #13663

Merged
merged 1 commit into from Feb 28, 2017

Conversation

tchaikov
Copy link
Contributor

if we run upgrade test, where, for example, "jewel" is not in
ceph-ci.git repo, we should check ceph.git to clone the workunits.

this fixes http://pulpito.ceph.com/kchai-2017-02-27_04:13:29-rados-wip-kefu-testing---basic-smithi/862549/

@tchaikov
Copy link
Contributor Author

it's a regression introduced by #13625

@idryomov
Copy link
Contributor

idryomov commented Feb 27, 2017

Ah, that's what it is for... No mention of "upgrade" in 72d73b8.

Have you tested this? The except branch seems to use git_url and not alt_git_url?

…workunit repo

if we run upgrade test, where, for example, "jewel" is not in
ceph-ci.git repo, we should check ceph.git to clone the workunits.

Signed-off-by: Kefu Chai <kchai@redhat.com>
@tchaikov
Copy link
Contributor Author

tchaikov commented Feb 27, 2017

@idryomov thanks for the review. fixed, and i am pushing this change to ceph-ci for testing. will update the PR with the link to the test run.

@tchaikov
Copy link
Contributor Author

@tchaikov
Copy link
Contributor Author

2017-02-27T18:20:37.613 INFO:teuthology.orchestra.run.mira026:Running: 'rm -rf /home/ubuntu/cephtest/clone.client.0 && git clone git://git.ceph.com/ceph-ci.git /home/ubuntu/cephtest/clone.client.0 && cd -- /home/ubuntu/cephtest/clone.client.0 && git checkout jewel'
2017-02-27T18:20:38.137 INFO:tasks.workunit.client.0.mira026.stderr:Cloning into '/home/ubuntu/cephtest/clone.client.0'...
2017-02-27T18:21:06.629 INFO:tasks.workunit.client.0.mira026.stderr:error: pathspec 'jewel' did not match any file(s) known to git.
2017-02-27T18:21:06.631 INFO:tasks.workunit:failed to check out 'jewel' from git://git.ceph.com/ceph-ci.git; will also try in git://git.ceph.com/ceph.git
2017-02-27T18:21:06.631 INFO:teuthology.orchestra.run.mira026:Running: 'rm -rf /home/ubuntu/cephtest/clone.client.0 && git clone git://git.ceph.com/ceph.git /home/ubuntu/cephtest/clone.client.0 && cd -- /home/ubuntu/cephtest/clone.client.0 && git checkout jewel'
2017-02-27T18:21:07.053 INFO:tasks.workunit.client.0.mira026.stderr:Cloning into '/home/ubuntu/cephtest/clone.client.0'...
2017-02-27T18:25:23.889 INFO:tasks.workunit.client.0.mira026.stderr:Switched to a new branch 'jewel'
2017-02-27T18:25:23.937 INFO:tasks.workunit.client.0.mira026.stdout:Branch jewel set up to track remote branch jewel from origin.

Copy link

@dillaman dillaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tchaikov tchaikov merged commit ae85309 into ceph:master Feb 28, 2017
@tchaikov tchaikov deleted the wip-ceph-git-for-workunit branch February 28, 2017 02:32
@smithfarm
Copy link
Contributor

Should #13625 and this PR be backported?

@tchaikov
Copy link
Contributor Author

tchaikov commented Mar 6, 2017

@smithfarm they improve the developer's user experience when testing using the tasks in qa suites. but it's not a user visible change. so i think it's just nice to backport them, but not required.

@idryomov
Copy link
Contributor

idryomov commented Mar 6, 2017

Might want to hold the backporting for another week or two until we are sure there are no regressions. People seem to be having issues in this area: http://tracker.ceph.com/issues/19188.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants