osd/OSDMap: don't set weight to IN when OSD is destroyed #13730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After some discussion with @liewegas we've decided to go ahead with reverting the breakage and documenting how to avoid being bit on upgrades. This affects jewel, kraken and master. |
|
Better to remove the line entirely and not touch the osd_weight because the OSD might have been marked in and setting it out will also change the mapping incompatibly with hammer and earlier. |
|
Yeah, I missed that we only check for down. |
Since commit 4e28f9e ("osd/OSDMap: clear osd_info, osd_xinfo on osd deletion"), weight is set to IN when OSD is deleted. This changes the result of applying an incremental for clients, not just OSDs. Because CRUSH computations are obviously affected, pre-4e28f9e63644 servers disagree with post-4e28f9e63644 clients on object placement, resulting in misdirected requests. Fixes: http://tracker.ceph.com/issues/19119 Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
idryomov
force-pushed
the
wip-osd-rm-incremental
branch
from
a28e81a
to
a6009d1
Compare
liewegas
approved these changes
Mar 1, 2017
|
I'll submit a separate set of PRs with release notes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since commit 4e28f9e ("osd/OSDMap: clear osd_info, osd_xinfo on
osd deletion"), weight is set to IN when OSD is deleted. This changes
the result of applying an incremental for clients, not just OSDs.
Because CRUSH computations are obviously affected, pre-4e28f9e63644
servers disagree with post-4e28f9e63644 clients on object placement,
resulting in misdirected requests.
Fixes: http://tracker.ceph.com/issues/19119
Signed-off-by: Ilya Dryomov idryomov@gmail.com