Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

librados: replace the var name from onack to complete #13857

Merged
merged 1 commit into from Mar 9, 2017
Merged

librados: replace the var name from onack to complete #13857

merged 1 commit into from Mar 9, 2017

Conversation

liupan1111
Copy link
Contributor

@liupan1111 liupan1111 commented Mar 8, 2017 •
edited

No description provided.

@liupan1111
Copy link
Contributor Author

@tchaikov , please help take a look, thanks!

@liupan1111 liupan1111 requested a review from tchaikov March 8, 2017 12:03
@liupan1111
Copy link
Contributor Author

After thinking, I think oncomplete is better... @liewegas @tchaikov , what do you think?

@liupan1111
Copy link
Contributor Author

af01db7

@liewegas
Copy link
Member

liewegas commented Mar 8, 2017

"oncomplete" seems clearer, yeah

@liupan1111 liupan1111 changed the title librados: replace the var name from onact to oncommit for write/remov… librados: replace the var name from onact to oncommit, which is clearer. Mar 9, 2017
@liupan1111
Copy link
Contributor Author

@liewegas Done.

@liewegas liewegas changed the title librados: replace the var name from onact to oncommit, which is clearer. librados: replace the var name from onack to complete Mar 9, 2017
@liewegas
Copy link
Member

liewegas commented Mar 9, 2017

can you update the commit description to match the new name? otherwise, lgtm!

librados: replace the var name from onact to oncomplete.
ff8b601 
Signed-off-by: Pan Liu <pan.liu@istuary.com>
@liupan1111
Copy link
Contributor Author

@liewegas updated the commit description, thanks!

@liewegas liewegas merged commit 83d0704 into ceph:master Mar 9, 2017
@liupan1111 liupan1111 deleted the wip-rename-onack-to-oncommit branch March 9, 2017 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liewegas liewegas liewegas approved these changes

@tchaikov tchaikov Awaiting requested review from tchaikov

Assignees
No one assigned
Labels
cleanup core
Projects
None yet
Milestone
No milestone
2 participants
@liupan1111 @liewegas