mds: fix handling very fast delete ops #13899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deletions can complete so quickly that we're ready to call execute_item_complete before the end of execute_item. We could use a finisher here so that the completion was always called from outside PurgeQueue::lock, but it's more efficient to just handle the inline case directly. Fixes: http://tracker.ceph.com/issues/19245 Signed-off-by: John Spray <john.spray@redhat.com>
|
|
|
It works. mds no longer crashes during multimds test |
ukernel
approved these changes
Mar 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deletions can complete so quickly that we're
ready to call execute_item_complete before
the end of execute_item. We could use a finisher
here so that the completion was always called
from outside PurgeQueue::lock, but it's more efficient
to just handle the inline case directly.
Fixes: http://tracker.ceph.com/issues/19245
Signed-off-by: John Spray john.spray@redhat.com