rbd: prevent adding multiple mirror peers to a single pool #13919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trociny
reviewed
Mar 11, 2017
src/librbd/api/Mirror.cc
Outdated
| @@ -681,7 +681,6 @@ int Mirror<I>::peer_add(librados::IoCtx& io_ctx, std::string *uuid, | |||
| return -EINVAL; | |||
| } | |||
|
|
|||
| int r; | |||
There was a problem hiding this comment.
@dillaman see jenkins build error
dillaman
changed the title
The rbd-mirror daemon does not currently support replication from multiple peers. Until that is supported, add a temporary restriction to prevent confusion. Fixes: http://tracker.ceph.com/issues/19256 Signed-off-by: Jason Dillaman <dillaman@redhat.com>
|
Looks Good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rbd-mirror daemon does not currently support replication
from multiple peers. Until that is supported, add a temporary
restriction to prevent confusion.
Fixes: http://tracker.ceph.com/issues/19256
Signed-off-by: Jason Dillaman dillaman@redhat.com