rgw_file: fix double unref on rgw_fh for rename #13988
Conversation
|
@guihecheng I think you're right about the double unref (not double free, since we are refcounting), but I think my intent (see comment in case 1 /*!LOCKED, -ref */) in the code was that the unlink would be the last valid access to rgw_fh, so rather than omitting to unlock and unref in unlink, we should goto out or return here in rename, because we are not supposed to touch rgw_fh after unlinking it. Can you buy that? |
|
@mattbenjamin ok, it is reasonable that unlink should always be the one to kill an fh, thanks. |
Skip unref after unlink to fix the problem. Signed-off-by: Gui Hecheng <guihecheng@cmss.chinamobile.com>
guihecheng
changed the title
guihecheng
force-pushed
the
rgw_file-fix-rename
branch
from
4d3c907
to
bff2287
Compare
|
My fault the submodule test failed, ignore |
|
@guihecheng this appears to work perfectly, combined w/Dan's version of the nfs-ganesha invalidate-for-rename change (sorry again that was lost, and thanks for root-causing and proposing a fix!) |
|
verified f23 |
ghost
mentioned this pull request
Skip unref after unlink to fix the problem.
Signed-off-by: Gui Hecheng guihecheng@cmss.chinamobile.com