Wip mon paxos fixes #230
Merged
Wip mon paxos fixes #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 18, 2013 09:58
Signed-off-by: Joao Eduardo Luis <joao.luis@inktank.com>
Say a service establishes it will only keep 500 versions once a given
condition X is true. Now say that said condition X only becomes true
after said service committing some 800 versions.
Once we decide to trim, this service would trim all 300 surplus versions
in one go. After that, each committed version would also trim the
previous version.
Trimming an unbounded number of versions is not a good practice
as it will generate bigger transactions (thus a greater workload on
leveldb) and therefore bigger messages too.
Constantly trimming versions implies more frequent accesses to leveldb,
and keeping around a couple more versions won't hurt us in any significant
way, so let us put off trimming unless we go over a predefined minimum.
This patch adds two new options:
paxos service trim min - minimum amount of versions to trigger a trim
(default: 30, 0 disables it)
paxos service trim max - maximum amount of versions to trim during a
single proposal
(default: 50, 0 disables it)
Signed-off-by: Joao Eduardo Luis <joao.luis@inktank.com>
| @@ -75,7 +75,7 @@ class MDSMonitor : public PaxosService { | |||
| // we don't require full versions; don't encode any. | |||
| virtual void encode_full(MonitorDBStore::Transaction *t) { } | |||
|
|
|||
| bool should_trim() { return false; } | |||
| bool service_should_trim() { return false; } | |||
There was a problem hiding this comment.
Huh, do we really never trim MDSMaps?
|
So we're now sharding a big trim into multiple smaller trim requests. Have you tested this to make sure that sufficiently breaks up the workload, or do we need to try and have a minimum interval between trims too? :/ |
|
I can't guarantee that it will enhance overall performance. It should however avoid big transactions when we trim osdmaps, instead splitting those trims in multiple smaller transactions. Having a minimum interval between trims would probably build up on the amount of versions we would need to trim without any significant gain. Then again, this is pure speculation. |
liewegas
pushed a commit
that referenced
this pull request
Apr 22, 2013
Wip mon paxos fixes Reviewed-by: Greg Farnum <greg@inktank.com> Reviewed-by: Sage Weil <sage@inktank.com>
liewegas
pushed a commit
that referenced
this pull request
Dec 14, 2016
rgw: allow fastcgi idle timeout to be adjusted Reviewed-by: Yehuda Sadeh <yehuda@inktank.com>
liewegas
pushed a commit
to liewegas/ceph
that referenced
this pull request
Nov 5, 2021
Changes to ansible post go-live
tserong
pushed a commit
to tserong/ceph
that referenced
this pull request
Oct 18, 2023
rgw/sfs: Don't return version id for unversioned buckets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating this for Joao to track comments on.