Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wip mon paxos fixes #230

Merged
merged 2 commits into from Apr 22, 2013
Merged

Wip mon paxos fixes #230

merged 2 commits into from Apr 22, 2013

Commits on Apr 18, 2013

  1. mon: Paxos: increase debug levels for proposal listing

    Signed-off-by: Joao Eduardo Luis <joao.luis@inktank.com>
    Joao Eduardo Luis committed Apr 18, 2013
    Copy the full SHA
    5a5fdfc View commit details
    Browse the repository at this point in the history
  2. mon: PaxosService: fix trim criteria so to avoid constantly trimming

    Say a service establishes it will only keep 500 versions once a given
    condition X is true.  Now say that said condition X only becomes true
    after said service committing some 800 versions.
    
    Once we decide to trim, this service would trim all 300 surplus versions
    in one go.  After that, each committed version would also trim the
    previous version.
    
    Trimming an unbounded number of versions is not a good practice
    as it will generate bigger transactions (thus a greater workload on
    leveldb) and therefore bigger messages too.
    
    Constantly trimming versions implies more frequent accesses to leveldb,
    and keeping around a couple more versions won't hurt us in any significant
    way, so let us put off trimming unless we go over a predefined minimum.
    
    This patch adds two new options:
    
     paxos service trim min - minimum amount of versions to trigger a trim
                              (default: 30, 0 disables it)
     paxos service trim max - maximum amount of versions to trim during a
                              single proposal
                              (default: 50, 0 disables it)
    
    Signed-off-by: Joao Eduardo Luis <joao.luis@inktank.com>
    Joao Eduardo Luis committed Apr 18, 2013
    Copy the full SHA
    4b34b0e View commit details
    Browse the repository at this point in the history