osd: requeue blocked op before flush it was blocked on #3931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we have request A (say, cache-flush) that blocks things, and then request B that gets blocked on it, and we have an interval change, then we need to requeue B first, then A, so that the resulting queue will keep A before B and preserve the order. This was observed on this firefly run: ubuntu@teuthology:/a/sage-2015-01-09_21:43:43-rados-firefly-distro-basic-multi/694675 Backport: giant, firefly Fixes: #10512 Signed-off-by: Sage Weil <sage@redhat.com> (cherry picked from commit 11bdfb4)
ghost
added
|
SUCCESS: the output of run-make-check.sh on centos-7 for 2ad509d is http://paste2.org/1VMBFjW4 |
Sent from 
|
lgtm |
ghost
pushed a commit
that referenced
this pull request
Mar 16, 2015
osd: requeue blocked op before flush it was blocked on Reviewed-by: Samuel Just <sjust@redhat.com>
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we have request A (say, cache-flush) that blocks things, and then
request B that gets blocked on it, and we have an interval change, then we
need to requeue B first, then A, so that the resulting queue will keep
A before B and preserve the order.
This was observed on this firefly run:
ubuntu@teuthology:/a/sage-2015-01-09_21:43:43-rados-firefly-distro-basic-multi/694675
Backport: giant, firefly
Fixes: #10512
Signed-off-by: Sage Weil sage@redhat.com
(cherry picked from commit 11bdfb4)