osd: DBObjectMap: lock header_lock on sync() #3948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, we can race with another thread updating state.seq resulting in the old, smaller value getting persisted. If there is a crash at that time, we will reuse a sequence number, resulting in an inconsistent node tree and bug #9891. Fixes: 9891 Backport: giant, firefly, dumpling Signed-off-by: Samuel Just <sjust@redhat.com> (cherry picked from commit 2b63dd2) Conflicts: src/os/DBObjectMap.cc because we have state.v = 1; instead of state.v = 2;
|
SUCCESS: the output of run-make-check.sh on centos-7 for 8c4f35a is http://paste2.org/EE1CNkbN |
Sent from 
|
lgtm |
ghost
pushed a commit
that referenced
this pull request
Mar 16, 2015
DBObjectMap: lock header_lock on sync() Reviewed-by: Samuel Just <sjust@redhat.com>
ghost
merged commit 
ghost
changed the title
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/9891
Otherwise, we can race with another thread updating state.seq
resulting in the old, smaller value getting persisted. If there
is a crash at that time, we will reuse a sequence number, resulting
in an inconsistent node tree and bug #9891.
Fixes: 9891
Backport: giant, firefly, dumpling
Signed-off-by: Samuel Just sjust@redhat.com
(cherry picked from commit 2b63dd2)
Conflicts:
src/os/DBObjectMap.cc
because we have state.v = 1; instead of state.v = 2;