osd: ObjectStore: Don't use largest_data_off to calc data_align. #3954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If largest_data_off % CEPH_PAGE_SIZE != 0, the get_data_aligment return a erro value. This make the FileJouranl::align_bl to memcopy much data. Tested-by: Sage Weil <sage@redhat.com> Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com> (cherry picked from commit a1aa70f)
|
SUCCESS: the output of run-make-check.sh on centos-7 for 8fd3ea7 is http://paste2.org/D5GfmwDb |
Sent from 
|
lgtm |
ghost
pushed a commit
that referenced
this pull request
Mar 16, 2015
ObjectStore: Don't use largest_data_off to calc data_align. Reviewed-by: Samuel Just <sjust@redhat.com>
ghost
merged commit 
ghost
changed the title
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/10014
If largest_data_off % CEPH_PAGE_SIZE != 0, the get_data_aligment return
a erro value. This make the FileJouranl::align_bl to memcopy much data.
Tested-by: Sage Weil sage@redhat.com
Signed-off-by: Jianpeng Ma jianpeng.ma@intel.com
(cherry picked from commit a1aa70f)