tools: use a new disk as journal disk,ceph-disk prepare fail #4630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases, depending on the implementation or the operating system, parted --machine -- /dev/sdh print may contain empty lines. The current parsing code is fragile and highly depends on output details. Replace it with code that basically does the same sanity checks (output not empty, existence of units, existence of the dev entry) but handles the entire output instead of checking line by line. http://tracker.ceph.com/issues/10983 Fixes: ceph#10983 Signed-off-by: Loic Dachary <ldachary@redhat.com> (cherry picked from commit f5acf6b)
ghost
changed the title
|
this part of the ceph-disk code is used by all tests when preparing new disks attached to each machine running an OSD. http://pulpito.ceph.com/loic-2015-07-09_21:09:04-rados-firefly-backports---basic-multi is all green, therefore this backport works as it should. |
ghost
pushed a commit
that referenced
this pull request
Jul 21, 2015
tools: use a new disk as journal disk,ceph-disk prepare fail Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
merged commit 
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/10983