common: OPT_INT option interprets 3221225472 as -1073741824, and crashes in Throttle::Throttle() #4889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* #include "strtol.h" in strtol.cc, to ensure the function defintions are consistent. * add a test accordingly * fix the testcase of converting 1024E. * do not accept integers overflow after adding SI suffix * do not accept integers underflow (i.e. negative values) Fixes: ceph#11484 Signed-off-by: Kefu Chai <kchai@redhat.com> (cherry picked from commit d62f80d)
Signed-off-by: Kefu Chai <kchai@redhat.com> (cherry picked from commit 1ff409e)
|
@theanalyst if I'm not mistaken the issue in the pull request description should be http://tracker.ceph.com/issues/11738 instead of http://tracker.ceph.com/issues/11484 |
|
I mean #4889 (comment) should be http://tracker.ceph.com/issues/11738 right ? |
|
Yes.. sorry.. updated |
|
@athanatos / @tchaikov this has passed the first round of integration tests for hammer backports at http://tracker.ceph.com/issues/11990#rados Do you think it is ready to merge |
|
👍 |
ghost
pushed a commit
that referenced
this pull request
Jul 10, 2015
OPT_INT option interprets 3221225472 as -1073741824, and crashes in Throttle::Throttle() Reviewed-by: Kefu Chai <kchai@redhat.com>
ghost
merged commit 
ghost
changed the title
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/11738