crush: take crashes due to invalid arg #4891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Verify that the 'take' argument is a valid device or bucket. Otherwise, ignore it (do not add the value to the working vector). Backport: hammer, firefly Fixes: ceph#11602 Reported-by: shiva rkreddy <shiva.rkreddy@gmail.com> Signed-off-by: Sage Weil <sage@redhat.com> (cherry picked from commit 9324d0a)
If a rule references a bucket with 'take', prevent deletion. Fixes: ceph#11602 Signed-off-by: Sage Weil <sage@redhat.com> (cherry picked from commit 3d591af)
|
@athanatos / @liewegas This has passed the first round of integration tests for hammer at http://tracker.ceph.com/issues/11990#rados Do you think it is ready for merge ? |
|
This one you should run by @tchaikov , I think. |
ghost
pushed a commit
that referenced
this pull request
Jul 15, 2015
crush: take crashes due to invalid arg Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
merged commit
ghost
pushed a commit
that referenced
this pull request
Jul 15, 2015
Reviewed-by: Loic Dachary <ldachary@redhat.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/11740