fs: cephfs Dumper tries to load whole journal into memory at once #5120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously tried to read entire journal into memory in one go, which was problematic for large journals. Fixes: ceph#11746 Signed-off-by: John Spray <john.spray@redhat.com> (cherry picked from commit e3ddcb8)
ghost
pushed a commit
that referenced
this pull request
Jul 15, 2015
…nto memory at once Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Jul 15, 2015
…nto memory at once Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Jul 16, 2015
…nto memory at once Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Jul 19, 2015
…nto memory at once Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Jul 19, 2015
…nto memory at once Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Jul 19, 2015
…nto memory at once Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Jul 19, 2015
…nto memory at once Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Jul 19, 2015
…nto memory at once Reviewed-by: Loic Dachary <ldachary@redhat.com>
|
@gregsfortytwo does this hammer backport looks good to merge ? It went through a fs suite ( http://tracker.ceph.com/issues/11990#fs ). |
ghost
pushed a commit
that referenced
this pull request
Jul 29, 2015
…nto memory at once Reviewed-by:
|
LGTM |
ghost
pushed a commit
that referenced
this pull request
Jul 30, 2015
cephfs Dumper tries to load whole journal into memory at once Reviewed-by: Greg Farnum <gfarnum@redhat.com>
ghost
merged commit 
ghost
changed the title
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/11999