rgw: radosgw-admin dumps user info twice #5286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… user info.
remove rgw_admin.cc OPT_SUBUSER_MODIFY, show_user_info code block.
switch (opt_cmd) {
...
case OPT_SUBUSER_MODIFY:
show_user_info(info, formatter); //show first time (remove this)
break;
...
}
// output the result of a user operation
if (output_user_info) {
...
show_user_info(info, formatter); //show second time
}
test fix:
before: after subuser modify print twice user info.
after changes, do the same procedure, print only once user info.
Signed-off-by: guce guce@h3c.com
(cherry picked from commit c604dd9)
ghost
pushed a commit
that referenced
this pull request
Jul 19, 2015
Reviewed-by: Loic Dachary <ldachary@redhat.com>
|
@yehudasa does this hammer backport looks good to merge ? It went through a rgw suite ( http://tracker.ceph.com/issues/11990#rgw ), only one job failed because of a radosgw-agent failure specific to Ubuntu 12.04 (but succeded on 14.04). |
ghost
pushed a commit
that referenced
this pull request
Jul 29, 2015
ghost
pushed a commit
that referenced
this pull request
Jul 31, 2015
rgw: radosgw-admin dumps user info twice Reviewed-by: Yehuda Sadeh <ysadehwe@redhat.com>
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/12400