tools: ceph-disk: sometimes the journal symlink is not created #5541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When reusing a journal partition (e.g. /dev/sda2) we should set a new partition guid and link it correctly with the OSD. This way the journal is symlinked by its persistent name and ceph-disk list works correctly. Signed-off-by: Dan van der Ster <daniel.vanderster@cern.ch> (cherry picked from commit beff616)
We observe that the new /dev/disk/by-partuuid/<journal_uuid> symlink is not always created by udev when reusing a journal partition. Fix by not changing the uuid of a journal partition in this case -- instead we can reuse the existing uuid (and journal_symlink) instead. We also now assert that the symlink exists before further preparing the OSD. Fixes: #10146 Signed-off-by: Dan van der Ster <daniel.vanderster@cern.ch> Tested-by: Dan van der Ster <daniel.vanderster@cern.ch> (cherry picked from commit 29eb135)
ghost
pushed a commit
that referenced
this pull request
Oct 20, 2015
… not created Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Oct 20, 2015
ceph-disk: sometimes the journal symlink is not created Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
merged commit 
ghost
changed the title
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/12418