common: recursive lock of md_config_t (0) #5814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lockdep can't handle recursive locks, resulting in false positive reports for certain set_val_or_die() calls, like via md_config_t::parse_argv() passed "-m". Fixes: ceph#12614 Signed-off-by: Josh Durgin <jdurgin@redhat.com> (cherry picked from commit 4152269)
ghost
pushed a commit
that referenced
this pull request
Oct 20, 2015
Reviewed-by: Loic Dachary <ldachary@redhat.com>
|
@liewegas does this backport look good to merge ? It passed a run of the firefly rados suite ( see http://tracker.ceph.com/issues/11644#note-110 ). Note that there was a valgrind issues but it is unrelated and fixed by #6325. |
|
👍 |
ghost
pushed a commit
that referenced
this pull request
Oct 20, 2015
recursive lock of md_config_t (0) Reviewed-by: Sage Weil <sage@redhat.com>
ghost
merged commit 
ghost
changed the title
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/12840