Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hammer: mon: check for store writeablility before participating in election #6144

Merged
2 commits merged into from Nov 10, 2015
Merged

hammer: mon: check for store writeablility before participating in election #6144

2 commits merged into from Nov 10, 2015

Conversation

ghost
Copy link

@ghost ghost commented Oct 2, 2015

Do this globally intead of relying on teh zillion mon callers to
check the error code.  There are no cases where we want to
tolerate a commit failure.

Fixes: #13089
Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit 2fb7b1f)
Currently we already do a small write when the *first* election in
a round happens (to update the election epoch).  If the backend
happens to fail while we are already in the midst of elections,
however, we may continue to call elections without verifying we
are still writeable.

Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit ef909cc)
@ghost ghost self-assigned this Oct 2, 2015
@ghost ghost added this to the hammer milestone Oct 2, 2015
@ghost ghost added bug-fix core labels Oct 2, 2015
ghost pushed a commit that referenced this pull request Oct 2, 2015
…articipating in election

Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost pushed a commit that referenced this pull request Oct 3, 2015
…articipating in election

Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost pushed a commit that referenced this pull request Oct 3, 2015
…articipating in election

Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost pushed a commit that referenced this pull request Oct 3, 2015
…articipating in election

Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost pushed a commit that referenced this pull request Oct 7, 2015
…articipating in election

Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost pushed a commit that referenced this pull request Oct 8, 2015
…articipating in election

Reviewed-by: Loic Dachary <ldachary@redhat.com>
@ghost
Copy link
Author

ghost commented Nov 4, 2015

@liewegas does this backport look good to merge ? It passed a run of the hammer rados suite ( see http://tracker.ceph.com/issues/13356#note-11 and for details ).

@liewegas
Copy link
Member

liewegas commented Nov 6, 2015

👍

ghost pushed a commit that referenced this pull request Nov 10, 2015
mon: check for store writeablility before participating in election

Reviewed-by: Sage Weil <sage@redhat.com>
@ghost ghost merged commit d87d136 into ceph:hammer Nov 10, 2015
ghost pushed a commit that referenced this pull request Nov 17, 2015
mon: check for store writeablility before participating in election

Reviewed-by: Sage Weil <sage@redhat.com>
ghost pushed a commit that referenced this pull request Nov 17, 2015
mon: check for store writeablility before participating in election

Reviewed-by: Sage Weil <sage@redhat.com>
ghost pushed a commit that referenced this pull request Nov 17, 2015
mon: check for store writeablility before participating in election

Reviewed-by: Sage Weil <sage@redhat.com>
ghost pushed a commit that referenced this pull request Nov 17, 2015
mon: check for store writeablility before participating in election

Reviewed-by: Sage Weil <sage@redhat.com>
ghost pushed a commit that referenced this pull request Nov 17, 2015
mon: check for store writeablility before participating in election

Reviewed-by: Sage Weil <sage@redhat.com>
@ghost ghost changed the title mon: check for store writeablility before participating in election hammer: mon: check for store writeablility before participating in election Feb 18, 2016
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants