stuck recovering, unfound hit set due to removing it while !active #6147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When hit set is not configured on startup or on a change, remove all previous hitsets. Signed-off-by: Zhiqiang Wang <zhiqiang.wang@intel.com> (cherry picked from commit be28319)
Only the primary PG is allowed to remove all the hit set objects. And the PG should be in the active or peered states. Signed-off-by: Zhiqiang Wang <zhiqiang.wang@intel.com> (cherry picked from commit fd38902)
Otherwise impl is unpopulated and we risk segfaults in several methods. It also seems like it would always indicate a bug. Signed-off-by: Samuel Just <sjust@redhat.com> (cherry picked from commit 8e5a801)
ghost
mentioned this pull request
ghost
pushed a commit
that referenced
this pull request
Oct 2, 2015
…moving it while !active Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Oct 3, 2015
…moving it while !active Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Oct 3, 2015
…moving it while !active Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Oct 3, 2015
…moving it while !active Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Oct 7, 2015
…moving it while !active Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Oct 8, 2015
…moving it while !active Reviewed-by: Loic Dachary <ldachary@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/13288