librados: do cleanup #6488
Merged
librados: do cleanup #6488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xiexingguo you might need to fix your |
remove unused local variable sName in rollback. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
Cast oid to object explicitly before call ioctx methods. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
Remove unused variables bl and bl2 in snap_list and ictx_refresh. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
xiexingguo
force-pushed
the
xxg-wip-rados-cleanup
branch
from
e49638c
to
f7f5a08
Compare
|
@tchaikov Fixup, please review. |
|
Looks all fine to me. |
|
Sorry for the wrong closing : "the Clsoe and comment" button was too close from the "comment" one for my fat fingers... |
|
lgtm also. |
tchaikov
added a commit
that referenced
this pull request
Nov 10, 2015
librados: do cleanup Reviewed-by: Sebastien Ponce <sebastien.ponce@cern.ch> Reviewed-by: Kefu Chai <kchai@redhat.com>
ghost
added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unused local variables and perform explicit cast when call ioctx methods.
Signed-off-by: xie xingguo xie.xingguo@zte.com.cn