hammer: client: added permission check based on getgrouplist #6604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ukernel
force-pushed
the
hammer-13268
branch
from
f37874a
to
71eea34
Compare
ghost
self-assigned this
ukernel
force-pushed
the
hammer-13268
branch
from
71eea34
to
19b76aa
Compare
ghost
pushed a commit
that referenced
this pull request
Jan 11, 2016
…grouplist Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Jan 11, 2016
…grouplist Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Jan 11, 2016
…grouplist Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Jan 15, 2016
…grouplist Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Jan 29, 2016
…grouplist Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Feb 1, 2016
…grouplist Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Feb 3, 2016
…grouplist Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Feb 9, 2016
…grouplist Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Feb 15, 2016
…grouplist Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Feb 16, 2016
…grouplist Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Feb 22, 2016
…grouplist Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
changed the title
|
@ukernel thanks ! Would you be so kind as to rebase this pull request ? That will fix the (unrelated to your work) make check failure. |
ghost
pushed a commit
that referenced
this pull request
Feb 26, 2016
…d on getgrouplist Reviewed-by: Loic Dachary <ldachary@redhat.com>
|
@gregsfortytwo does this backport look good to merge ? It passed a run of the hammer fs suite ( see http://tracker.ceph.com/issues/14692#note-25 for details ) except one test which does not seem to be related (http://pulpito.ceph.com/loic-2016-03-01_20:26:33-fs-hammer-backports---basic-multi/36755/). |
|
@ukernel could you please rebase to get a clean make check run ? |
Signed-off-by: Yan, Zheng <zyan@redhat.com> (cherry picked from commit 16b59c6)
Fixes: ceph#13268 Signed-off-by: Yan, Zheng <zyan@redhat.com> (cherry picked from commit f04c8da)
Fix handling of realloc. If realloc() fails it returns NULL, assigning the return value of realloc() directly to the pointer without checking for the result will lead to a memory leak. Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de> Signed-off-by: Yan, Zheng <zyan@redhat.com> (cherry picked from commit 4f98dab)
Fix for: [src/client/Client.cc:4555]: (style) The scope of the variable 'initial_group_count' can be reduced. Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de> Signed-off-by: Yan, Zheng <zyan@redhat.com> (cherry picked from commit a29dd45)
When handling an operation, libcephfs code may want to access fuse request for extra information. by tracking fuse request in thread local data, we can avoid adding extra parameter to Client::ll_foo functions. Signed-off-by: Yan, Zheng <zyan@redhat.com> (cherry picked from commit a9f91d7)
Signed-off-by: Yan, Zheng <zyan@redhat.com> (cherry picked from commit 0eb6d0b)
ghost
pushed a commit
that referenced
this pull request
Mar 4, 2016
…d on getgrouplist Reviewed-by: Loic Dachary <ldachary@redhat.com>
|
Looks fine to me @dachary |
ghost
pushed a commit
that referenced
this pull request
Mar 8, 2016
hammer: client: added permission check based on getgrouplist Reviewed-by: Greg Farnum <gfarnum@redhat.com>
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/13809