Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mon: fix reuse of osd ids (clear osd info on osd deletion) #6900

Merged
merged 2 commits into from Dec 18, 2015

Commits on Dec 10, 2015

  1. tests: verify it is possible to reuse an OSD id

    When an OSD id is removed via ceph osd rm, it will be reused by the next
    ceph osd create command. Verify that and OSD reusing such an id
    successfully comes up.
    
    http://tracker.ceph.com/issues/13988 Refs: ceph#13988
    
    Signed-off-by: Loic Dachary <loic@dachary.org>
    ldachary committed Dec 10, 2015
    Configuration menu
    Copy the full SHA
    c6cdc33 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2015

  1. osd/OSDMap: clear osd_info, osd_xinfo on osd deletion

    If we destroy an OSD in the map, clear not just the uuid but also
    all the metadata about it.
    
    Specifically, we care about up_from, which can prevent a new
    OSD from booting if it starts with a map prior to the deletion
    when it sends it boot.  Specifically, the osd epoch may be 0 and
    if the latest osd epoch is also small the osd decide it is "close
    enough" to the latest epoch and sends the boot message.  In
    practice this problem wouldn't surface on any cluster that isn't
    brand new.
    
    Note that this changes the result of applying an incremental.
    As such, it will cause lots of old OSDs to request full maps
    from the mon, spiking load during an upgrade.  This is as it
    should be.
    
    Fixes: ceph#13988
    Signed-off-by: Sage Weil <sage@redhat.com>
    liewegas committed Dec 11, 2015
    Configuration menu
    Copy the full SHA
    4e28f9e View commit details
    Browse the repository at this point in the history