hammer: osd: osd/ReplicatedPG: Recency fix #7207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
ghost
pushed a commit
that referenced
this pull request
Jan 15, 2016
…ammer Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
self-assigned this
ghost
changed the title
|
@rldleblanc could you please add details about why the conflicts happened and how you resolved them, in the commit message ? This is explained at http://tracker.ceph.com/projects/ceph-releases/wiki/HOWTO_backport_commits near "if there is a conflict". |
Recency is defined as how many of the last N hitsets an object must appear in in order to be promoted. The previous logic did nothing of the sort... it checked for the object in any one of the last N hitsets, which led to way to many promotions and killed any chance of the cache performing properly. While we are here, we can simplify the code to drop the max_in_* fields (no longer necessary). Note that we may still want a notion of 'temperature' that does tolerate the object missing in one of the recent hitsets.. but that would be different than recency, and should probably be modeled after the eviction temperature model. Backport: infernalis, hammer Reported-by: Nick Fisk <nick@fisk.me.uk> Signed-off-by: Sage Weil <sage@redhat.com> (cherry picked from commit 180c874) Conflicts: src/osd/ReplicatedPG.cc code section was moved to ReplicatedPG::maybe_promote in master. Signed-off-by: Robert LeBlanc <robert.leblanc@endurance.com>
Reported-by: xinxin shu <xinxin.shu@intel.com> Signed-off-by: Sage Weil <sage@redhat.com> (cherry picked from commit 528eae9) Conflicts: src/osd/ReplicatedPG.cc code section was moved to ReplicatedPG::maybe_promote in master. Signed-off-by: Robert LeBlanc <robert.leblanc@endurance.com>
rldleblanc
force-pushed
the
recency_fix_for_hammer
branch
from
f454c1b
to
ae56de0
Compare
ghost
changed the title
liewegas
added a commit
that referenced
this pull request
Jan 31, 2016
hammer: osd/ReplicatedPG: Recency fix for Hammer Reviewed-by: Sage Weil <sage@redhat.com>
ghost
changed the title
ghost
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/14329
This is a backport of #6702. This PR was created due to no movement of #7024 and I'd really like to have this in the next Hammer version.