Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hammer: osd: osd/ReplicatedPG: Recency fix #7207

Merged
merged 2 commits into from Jan 31, 2016
Merged

hammer: osd: osd/ReplicatedPG: Recency fix #7207

merged 2 commits into from Jan 31, 2016

Commits on Jan 29, 2016

  1. osd/ReplicatedPG: fix promotion recency logic 

    Recency is defined as how many of the last N hitsets an object
must appear in in order to be promoted.  The previous logic did
nothing of the sort... it checked for the object in any one of
the last N hitsets, which led to way to many promotions and killed
any chance of the cache performing properly.

While we are here, we can simplify the code to drop the max_in_*
fields (no longer necessary).

Note that we may still want a notion of 'temperature' that does
tolerate the object missing in one of the recent hitsets.. but
that would be different than recency, and should probably be
modeled after the eviction temperature model.

Backport: infernalis, hammer
Reported-by: Nick Fisk <nick@fisk.me.uk>
Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit 180c874)

Conflicts:
	src/osd/ReplicatedPG.cc
                    code section was moved to ReplicatedPG::maybe_promote
                    in master.
Signed-off-by: Robert LeBlanc <robert.leblanc@endurance.com>
    @liewegas
    liewegas authored and Robert LeBlanc committed Jan 29, 2016
    Configuration menu
    Copy the full SHA
    5cefcb9 View commit details
    Browse the repository at this point in the history

  2. osd: recency should look at newest (not oldest) hitsets 

    Reported-by: xinxin shu <xinxin.shu@intel.com>
Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit 528eae9)

Conflicts:
	src/osd/ReplicatedPG.cc
                    code section was moved to ReplicatedPG::maybe_promote
                    in master.
Signed-off-by: Robert LeBlanc <robert.leblanc@endurance.com>
    @liewegas
    liewegas authored and Robert LeBlanc committed Jan 29, 2016
    Configuration menu
    Copy the full SHA
    ae56de0 View commit details
    Browse the repository at this point in the history